Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work in IE (11) due to nodeList.forEach method call #7

Closed
mijnschoen opened this issue Oct 27, 2020 · 1 comment
Closed

Does not work in IE (11) due to nodeList.forEach method call #7

mijnschoen opened this issue Oct 27, 2020 · 1 comment
Assignees
@yuhui
Labels
bug Something isn't working

Comments

@mijnschoen
Copy link

Describe the bug
On IE11, the extension is not able to setup the players for the (iframe) elements, as an error is thrown: TypeError: Object doesn't support property or method 'forEach'

This is due to the nodeList type does nnot have a forEach method on IE.

To Reproduce
Use the extension on IE11

Expected behavior
It should work on IE11.

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Internet Explorer
  • Version: 11.1139.18362.0
@mijnschoen mijnschoen added the bug Something isn't working label Oct 27, 2020
@mijnschoen mijnschoen mentioned this issue Oct 27, 2020
Closed
@yuhui
Copy link
Owner

yuhui commented Nov 3, 2020

Superseded by #9 and #10

@yuhui yuhui closed this as completed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuhui yuhui

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix IE11 issue - missing nodeList.forEach mijnschoen/launchext-youtube-playback
2 participants
@yuhui @mijnschoen