Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pure-button link and button heights differ #221

Closed
janosrusiczki opened this issue Oct 17, 2013 · 7 comments
Closed

.pure-button link and button heights differ #221

janosrusiczki opened this issue Oct 17, 2013 · 7 comments

Comments

@janosrusiczki
Copy link

Hello,

I'm trying to create a form with a skip link right next to the submit button, and I only managed something as shown below:

safari

I'm using the following HTML:

<form action="/[...]" class="pure-form pure-form-stacked">  
  <fieldset>
    <label for="email">Email</label>
    <input class="pure-input-1-4" id="email" name="email" type="email" />
    <input class="pure-button" name="commit" type="submit" value="Submit" />
    <a href="/" class="pure-button">Skip</a>
  </fieldset>
</form>

The problem is, as you can see, that the link (Skip) is taller than the Submit button, even if they have the same class applied. I would like both of them to have the same height.

Or am I doing something wrong?

@narcis-radu
Copy link
Contributor

Can you give additional details? What browser/ os are you using? I tried Chrome, Firefox - latest, IE 7 - 10 on windows and I cannot reproduce the error. I ran the tests on http://jsfiddle.net/SE7xf/embedded/result/

@janosrusiczki
Copy link
Author

I forgot something important:

body {
  font-family: 'Open Sans', sans-serif;
}

Here's the updated fiddle: http://jsfiddle.net/SE7xf/1/embedded/result/

@janosrusiczki
Copy link
Author

I found a solution, but I don't know how valid it is.

I my overrides file I have the following:

.pure-g [class *="pure-u"], html, button, input, select, textarea {
  font-family: 'Open Sans', sans-serif;
}

This seems to be doing the trick.

@narcis-radu
Copy link
Contributor

a better solution is:

.pure-button {
    font-family: inherit;
}

@narcis-radu
Copy link
Contributor

@janosrusiczki
Copy link
Author

Multumesc mult. ;)

@narcis-radu
Copy link
Contributor

@kitsched n-ai pentru ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants