Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localized zh-Han* strings for Calendar #1007

Closed
wants to merge 6 commits into from
Closed

Conversation

shunner
Copy link
Contributor

@shunner shunner commented Jul 18, 2013

Add localized zh-Han* (except zh-HANT-TW that already exists) strings for Calendar.

According to "yui3/src/date/lang/datatype-date-format_zh-Han*.js" all 5 files, very_short_weekdays should remains the same set of characters.

Add localized zh-Hans-CN strings for Calendar. File contents are duplicated from the zh-HANS-TW version.
Add localized zh-Hans strings for Calendar. According to "yui3/src/date/lang/datatype-date-format_zh-Han*.js" all 5 files, very_short_weekdays remains the same set of characters.
Add localized zh-Hant strings for Calendar. According to "yui3/src/date/lang/datatype-date-format_zh-Han*.js" all 5 files, very_short_weekdays remains the same set of characters.
Add localized zh-Hant-HK strings for Calendar. According to "yui3/src/date/lang/datatype-date-format_zh-Han*.js" all 5 files, very_short_weekdays remains the same set of characters.
@okuryu
Copy link
Member

okuryu commented Jul 18, 2013

You need to update src/calendar/meta/calendar-base.json meta data.

@shunner
Copy link
Contributor Author

shunner commented Jul 18, 2013

Sorry for that, and thanks for notification~

On Thursday, July 18, 2013, Ryuichi Okumura wrote:

You need to update src/calendar/meta/calendar-base.json meta data.

¡ª
Reply to this email directly or view it on GitHubhttps://github.com//pull/1007#issuecomment-21188923
.

˳ף°²¿µ
С°×
Best wishes, Shun

"zh-Hans",
"zh-Hans-CN",
"zh-Hant",
"zh-Hant-HK",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not positive, but does Hant need to be all uppercase here—HANT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@okuryu do you think we should make these all uppercase simply for consistency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericf No. The format of language tags are defined by RFC5646. These are different depending on languages, regions, and son. Some language tags composed of several subtags. Order of the subtags that are described are defined as [language]-[script]-[region]-[variant]-[extension]-[private], but all subtags not required. Also single language tag format like [language] is valid. Therefore, the language tag called en is valid as [language] format, the language tag called en-US is valid as [language]-[region] format. zh-Hans and zh-Hant are comparable to [language]-[script] format, zh-Hans-CN and zh-Hans-HK are comparable to [language]-[script]-[region] format.

So I think these language tags are valid because they are registered in IANA Language Subtag Registry.

@ericf
Copy link
Member

ericf commented Jul 19, 2013

@okuryu thanks for the info :)

@shunner Can you add an entry to Calendar's HISTORY.md file to this describing this change and I'll merge it in. Thanks!

@shunner
Copy link
Contributor Author

shunner commented Jul 25, 2013

@ericf Sorry, I'm late. I hope that's what I should do in HISTORY.md.

@shunner
Copy link
Contributor Author

shunner commented Jul 30, 2013

@ericf anything I can do else for this pull request? Thanks~

ericf added a commit to ericf/yui3 that referenced this pull request Jul 31, 2013
@ericf
Copy link
Member

ericf commented Jul 31, 2013

Merged this…

@shunner shunner closed this Aug 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants