Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ScrollView units tests to not rely on cssreset #866

Open
derek opened this issue Jun 13, 2013 · 0 comments
Open

Update ScrollView units tests to not rely on cssreset #866

derek opened this issue Jun 13, 2013 · 0 comments

Comments

@derek
Copy link
Contributor

derek commented Jun 13, 2013

The cssreset component was deprecated in v3.9.0, but a few ScrollView unit tests rely on that reset to normalize styles so various IE browsers reports consistent values for testing.

Ideally, these tests should not rely on additional components (that is more an integration test), but if it is necessary, explore using cssnormalize instead.

Also, if a reset is required for ScrollView, that should be documented and possibly be a dependency. Though, I see issues with forcing a reset on the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant