Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream-based Extractor #164

Closed
sntran opened this issue Mar 12, 2023 · 1 comment
Closed

Stream-based Extractor #164

sntran opened this issue Mar 12, 2023 · 1 comment

Comments

@sntran
Copy link

sntran commented Mar 12, 2023

Currently, ExtractorData stores all data of the rar file in memory, and when extract() is called, each files inside are also kept in memory as Uint8Array extraction property.

This works fine for small rar file, but would run out of memory for big file.

Would you consider adding another Extractor that supports ReadableStream, both for the rar file, and the files inside it?

@YuJianrong
Copy link
Owner

It's hard since the Extractor is just a simple wrapper for the file writing API for unrarLib. So technically the unrarlib may not write the file sequentially is hard to rewrite to a streaming class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants