Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write the tests for Railtie in Rspec or the rest of the tests in Minitest #9

Open
yuki24 opened this issue Oct 2, 2018 · 0 comments

Comments

@yuki24
Copy link
Owner

yuki24 commented Oct 2, 2018

I had to use Minitest to move quickly and write tests for Artemis::Railtie, but obviously it is very odd to have two different testing frameworks in one gem. Here are some considerations:

  • Rspec does not have out-of-box support for Railtie testing and would require a significant amount of exploration and additional code
  • Rspec does not have a parallel test runner, which makes the test suite very slow (each Railtie test runs rails new to fully replicate a Rails app)
  • MInitest does not have a nice command that runs a single spec (Rspec is very good at this and Minitest is way behind)
  • The expect syntax generates an error message that's a lot more helpful than a simple assert
@yuki24 yuki24 changed the title Re-write the tests for Railtie in Rspec and the rest of the tests in Minitest Re-write the tests for Railtie in Rspec or the rest of the tests in Minitest Oct 4, 2018
@yuki24 yuki24 mentioned this issue Oct 9, 2018
3 tasks
@yuki24 yuki24 mentioned this issue Oct 30, 2018
4 tasks
@yuki24 yuki24 added this to Backlog in Third release: 0.3.0 Oct 30, 2018
@yuki24 yuki24 moved this from Backlog to Backlogg in Third release: 0.3.0 Oct 30, 2018
@yuki24 yuki24 removed this from Backlog in Third release: 0.3.0 Jan 21, 2019
@yuki24 yuki24 added this to Backlog in Version 0.5.0 Jan 21, 2019
@yuki24 yuki24 removed this from Backlog in Version 0.5.0 Jan 23, 2019
@yuki24 yuki24 added this to Backlog in Version 0.6.0 Jan 23, 2019
@yuki24 yuki24 removed this from Backlog in Version 0.6.0 Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant