Fix crash on update in background #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, `Row` would crash during `didEndDisplayCell` handling if table view is not on active controller (for example if there's modal controller on top of table view controller). The solution here is to simply ignore the call if `didEndDisplayCell` block is not assigned on `Row`. This preserves existing functionality for cases where block is used but prevents the crash otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
Rowwould crash duringdidEndDisplayCellhandling if table view is not on active controller (for example if there's modal controller on top of table view controller).The solution here is to simply ignore the call if
didEndDisplayCellblock is not assigned onRow. This preserves existing functionality for cases where block is used but prevents the crash otherwise.Besided crash fix, I also added ability to delete section from source.