fix(myanimelist): prevent failing when thumbnail is null

yukino-org · Nov 1, 2021 · 4df2742 · 4df2742
1 parent 72828ad
commit 4df2742
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/lib/modules/trackers/myanimelist/handlers/anime.dart b/lib/modules/trackers/myanimelist/handlers/anime.dart
@@ -18,14 +18,18 @@ class MyAnimeListSearchAnime {
       MyAnimeListSearchAnime(
         nodeId: json['node']['id'] as int,
         title: json['node']['title'] as String,
-        mainPictureMedium: json['node']['main_picture']['medium'] as String,
-        mainPictureLarge: json['node']['main_picture']['large'] as String,
+        mainPictureMedium: json['node']['main_picture'] != null
+            ? json['node']['main_picture']['medium'] as String
+            : null,
+        mainPictureLarge: json['node']['main_picture'] != null
+            ? json['node']['main_picture']['large'] as String
+            : null,
       );
 
   final int nodeId;
   final String title;
-  final String mainPictureMedium;
-  final String mainPictureLarge;
+  final String? mainPictureMedium;
+  final String? mainPictureLarge;
 
   static Future<List<MyAnimeListSearchAnime>> searchAnime(
     final String terms,

diff --git a/lib/modules/trackers/myanimelist/handlers/animelist.dart b/lib/modules/trackers/myanimelist/handlers/animelist.dart
@@ -273,7 +273,7 @@ class _DetailedItemWrapperState extends State<_DetailedItemWrapper>
   void didChangeDependencies() {
     super.didChangeDependencies();
 
-    maybeEmitReady();
+    hookState.markReady();
   }
 
   @override

diff --git a/lib/modules/trackers/myanimelist/handlers/mangalist.dart b/lib/modules/trackers/myanimelist/handlers/mangalist.dart
@@ -94,8 +94,12 @@ class MyAnimeListMangaList {
       MyAnimeListMangaList(
         nodeId: json['node']['id'] as int,
         title: json['node']['title'] as String,
-        mainPictureMedium: json['node']['main_picture']['medium'] as String,
-        mainPictureLarge: json['node']['main_picture']['large'] as String,
+        mainPictureMedium: json['node']['main_picture'] != null
+            ? json['node']['main_picture']['medium'] as String
+            : null,
+        mainPictureLarge: json['node']['main_picture'] != null
+            ? json['node']['main_picture']['large'] as String
+            : null,
         status: MyAnimeListMangaListProgress.fromJson(
           json['list_status'] as Map<dynamic, dynamic>,
         ),
@@ -125,8 +129,8 @@ class MyAnimeListMangaList {
 
   final int nodeId;
   final String title;
-  final String mainPictureMedium;
-  final String mainPictureLarge;
+  final String? mainPictureMedium;
+  final String? mainPictureLarge;
   MyAnimeListMangaListProgress? status;
   MyAnimeListMangaListAdditionalDetail? details;
 
@@ -319,7 +323,7 @@ class _DetailedItemWrapperState extends State<_DetailedItemWrapper>
   void didChangeDependencies() {
     super.didChangeDependencies();
 
-    maybeEmitReady();
+    hookState.markReady();
   }
 
   @override