Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

App chooses wrong stream quality (higher than device is capable of playing) #31

Closed
Maikell84 opened this issue Dec 6, 2017 · 5 comments
Labels

Comments

@Maikell84
Copy link
Contributor

I have an Allwinner A33 - device with Android 5.1.1. It has a 7 inch screen which has a physical resolution of 1024x600:

root@astar-yh:/ # wm size
Physical size: 1024x600

I am using the "4k-profile", since the others don't work properly, or require Crosswalk, which is not installed.

When I install the app (latest version 6.10.17), it plays the videos. However it often takes the FullHD stream! I have verified this, by navigating to "Quality" -> "Video" while the video was playing. (Please see attached screenshot)

screen

  • It should not download a higher stream-quality, than the device is capable of playing.
  • While this is not fixed: Can you please tell me where I could insert a monkey patch, to fix this for my device?

Thank you!

This is an awesome app by the way.

@yuliskov
Copy link
Owner

yuliskov commented Dec 8, 2017

Hi. There are problems down there.

  1. Android devices unable to report video output resolution. All I can get is interface resolution. One may differs depending on device. For example 4K boxes claim that they have 1080p resolution.
  2. Another chance would be to use codec capabilities. Yes, I can get list of supported codecs for your device. But again, most of device do it wrongly. I tested myself. Devices that unable to play specific codec/resolution often report that they can.

As you can see both soluton aren't perfect.

Resume. For now, the best practice would be to choose the resolution manually. All that I can promise is to maintain selected quality as long as possible.

@Maikell84
Copy link
Contributor Author

Hi Thank you for your detailled explanation. Ok if you cannot get the real video-output resolution it doesn't make sense do implement this feature.

Does a variable make sense to you, where you set the maximum possible stream-quality in the code? Maybe a static enum with values: 240p, 360p, 480p, ... and so on which defaults to 4k.

For my special use-case I have resolved it, by not displaying resolutions higher than 720p in TrackSelectionHelper.java, and by limiting the stream-Quality in PlayerActivity.java

I think you can close this issue.
Thank you.

@yuliskov
Copy link
Owner

yuliskov commented Dec 11, 2017

Hi. I could apply fix specifically for your device. For this purpose I need your the patch and device id (from CPU-Z).

@yuliskov
Copy link
Owner

Closed. Can't do precise resolution detection on api < 23.

@yuliskov yuliskov reopened this Feb 1, 2018
@yuliskov yuliskov added the bug label Feb 1, 2018
@yuliskov
Copy link
Owner

duplicate of #99

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants