feat(app): デバッグ機能へのアクセスをデバッグ実行時のみに制限 #278
Open
+85
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatsutakein
force-pushed
the
improve/GH-267
branch
from
0323f0e
to
d6e4072
Compare
yumemi-team-review-requester
bot
requested review from
a team,
Aosanori and
mqkotoo
and removed request for
a team
|
Ready for review 🚀 |
tatsutakein
commented
Jul 10, 2024
Comment on lines
+37
to
+44
| ...$appRoutes.where((route) { | ||
| if (route is GoRoute) { | ||
| return route.path != DebugPageRoute.path; | ||
| } | ||
|
|
||
| return true; | ||
| }), | ||
| if (kDebugMode) $debugPageRoute, |
There was a problem hiding this comment.
$appRoutes から一度デバッグ機能へのルートを外した状態で展開し、追加でデバッグ実行時にデバッグ機能へのルートを追加する形としています。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
デバッグ機能へのアクセスをデバッグ実行時のみに制限します。
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
リリースモードでの実行時に遷移しようとすると以下のようになります。
確認したこと
動作確認手順
デバッグ時とリリースモードでそれぞれ実行し、ホーム画面から確認できます。
備考