Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected signal to be an instanceof AbortSignal #11

Open
yumetodo opened this issue Aug 25, 2019 · 9 comments
Open

Expected signal to be an instanceof AbortSignal #11

yumetodo opened this issue Aug 25, 2019 · 9 comments
Labels
bug Something isn't working pending:dependences Status is blocked by dependences

Comments

@yumetodo
Copy link
Owner

album listを取る段階でコケている。

@yumetodo yumetodo added the bug Something isn't working label Aug 25, 2019
@yumetodo
Copy link
Owner Author

https://github.com/bitinn/node-fetch/blob/bf8b4e8db350ec76dbb9236620f774fcc21b8c12/src/request.js#L36-L43

constructor.nameがWebpackの最適化で書き換わるのが問題。
image

@yumetodo
Copy link
Owner Author

@yumetodo
Copy link
Owner Author

とりあえず
CartoDB/carto-vl#1066
のをworkaroundとして使う。

@yumetodo
Copy link
Owner Author

うーん、

  optimization: {
    minimizer: [
      new TerserPlugin({
        terserOptions: {
          mangle: false,
          keep_classnames: true,
          keep_fnames: true,
        },
      }),
    ],
  },

でこれそのものは解決したけど、Cannot read property '0' of undefinedが出る・・・

@yumetodo
Copy link
Owner Author

optimization.minimizefalseにしてもエラーになるのなぜ!?

@yumetodo
Copy link
Owner Author

いやというかoptimizeなしでもコケてるから別の問題だな

@yumetodo
Copy link
Owner Author

node-fetch/node-fetch#673
で解決。そのうちnode-fetchの3.xが来てgaxiosが更新されたらworkaroundもいらない。

@yumetodo yumetodo added the pending:dependences Status is blocked by dependences label Sep 24, 2019
@yumetodo
Copy link
Owner Author

v3.0.0-beta.2が出てる。もうそろそろか。
https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md

@yumetodo
Copy link
Owner Author

yumetodo commented Oct 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending:dependences Status is blocked by dependences
Projects
None yet
Development

No branches or pull requests

1 participant