Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build path should reflect Python version #29

Closed
mlouielu opened this issue Sep 21, 2020 · 3 comments · Fixed by #30
Closed

Build path should reflect Python version #29

mlouielu opened this issue Sep 21, 2020 · 3 comments · Fixed by #30

Comments

@mlouielu
Copy link
Contributor

mlouielu commented Sep 21, 2020

Spacetime BUILD_PATH is hard-coded as dev37 or dbg37.

It should somehow reflect the Python version used in the compile time:

$ make
...
-- Found PythonInterp: /usr/bin/python3.8 (found version "3.8.3") 
-- Found PythonLibs: /usr/lib/libpython3.8.so
-- pybind11_INCLUDE_DIRS: /usr/include;/usr/include/python3.8
...
-- Generating done
-- Build files have been written to: /dev/turgon/spacetime/build/dev37
make -C build/dev37 VERBOSE= _libst
make[1]: Entering directory '/dev/turgon/spacetime/build/dev37'
...
@mlouielu
Copy link
Contributor Author

mlouielu commented Sep 21, 2020

Trick like this will work:

➜  spacetime git:(master) ✗ python -c 'import sys; print(str(sys.version_info.major) + str(sys.version_info.minor))'
38

But Guido said there will have Python 3.10 1, then this trick output 310, hmm

@yungyuc
Copy link
Owner

yungyuc commented Sep 21, 2020

I think it makes sense. Do you mind to make a PR?

@mlouielu
Copy link
Contributor Author

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants