Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a thin jar instead of a jar with all its dependencies #65

Closed
wangzw opened this issue Oct 6, 2018 · 7 comments
Closed

Publish a thin jar instead of a jar with all its dependencies #65

wangzw opened this issue Oct 6, 2018 · 7 comments

Comments

@wangzw
Copy link

wangzw commented Oct 6, 2018

Since 2.2.9 only the fat jar is published to maven public repository. And it cause the conflict between the classes included into fat jar and third party jar from other vendor.

It cost me the whole afternoon to find the root cause.

@chengww5217
Copy link
Collaborator

You mean the source jar whom may be named as qingstor.sdk.java-2.2.9-sources.jar, has no longer been published to the maven public repository since 2.2.9?

@wangzw
Copy link
Author

wangzw commented Oct 8, 2018

Only 2.2.11-all-deps is published to public repository, but all-deps jar cause conflict with the jar from third-party. For example snakeyaml

https://mvnrepository.com/artifact/com.yunify/qingstor.sdk.java

@wangzw
Copy link
Author

wangzw commented Oct 8, 2018

The problem caused by all-deps jar is that you not only publish the code of qingstor SDK, you also publish the code which qingstor SDK depends on(packaged in the same jar), which cause the conflict for the user of all-deps jar.

@wangzw
Copy link
Author

wangzw commented Oct 8, 2018

Please remove all third-party dependency from qingstor SDK jar.

@chengww5217
Copy link
Collaborator

I see. You need a jar with none of its dependencies include. That's a nice request.

You know I have been asked to publish the jar all dependencies -- fat jar.

Okay, I'll publish both all dependencies and none dependency jar. Thank you for your feedback.

@chengww5217
Copy link
Collaborator

chengww5217 commented Oct 8, 2018

@wangzw Hey bro, a new version 2.2.12 of SDK has been published into the central repository. You can have a try.

PS: from now on, both thin and fat jar versions will be published like our github releases when make a release. If you wanna the fat jar, add the dependency named with version + -all-deps, else named with version.

@wangzw
Copy link
Author

wangzw commented Oct 8, 2018

Cool, thanks.

@wangzw wangzw closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants