feat(notify): Support 'socpe:domain' when list contacts #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary solution.
|
用这种markdown语法打勾： |
Codecov Report
@@ Coverage Diff @@
## master #6643 +/- ##
==========================================
+ Coverage 7.15% 7.16% +0.01%
==========================================
Files 647 647
Lines 109281 109281
==========================================
+ Hits 7818 7831 +13
+ Misses 100863 100850 -13
Partials 600 600
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yousong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yunion-ci-robot
added a commit
that referenced
this pull request
May 28, 2020
…pstream-release-3.1 Automated cherry pick of #6643: feat(notify): Support 'socpe:domain' when list contacts
yunion-ci-robot
added a commit
that referenced
this pull request
May 28, 2020
…pstream-release-3.2 Automated cherry pick of #6643: feat(notify): Support 'socpe:domain' when list contacts
rainzm
added a commit
to rainzm/onecloud
that referenced
this pull request
Jul 1, 2020
rainzm
added a commit
to rainzm/onecloud
that referenced
this pull request
Jul 1, 2020
rainzm
added a commit
to rainzm/onecloud
that referenced
this pull request
Jul 1, 2020
rainzm
added a commit
to rainzm/onecloud
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 实现什么功能/修复什么问题:
查询contacts列表是，支持scope=domain的参数，这是一种暂时的解决方案。
下个版本（3.3）想办法把 contacts 和 notifications 纳入到框架中。
是否需要 backport 到之前的 release 分支:
/cc @zexi
/area notify