Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #7459: fix cache non lvm disks #7460

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Automated cherry pick of #7459: fix cache non lvm disks #7460

merged 1 commit into from
Aug 1, 2020

Conversation

wanyaoqi
Copy link
Member

@wanyaoqi wanyaoqi commented Aug 1, 2020

Cherry pick of #7459 on release/3.3.

#7459: fix cache non lvm disks

@codecov-commenter
Copy link

Codecov Report

Merging #7460 into release/3.3 will decrease coverage by 1.52%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/3.3   #7460      +/-   ##
==============================================
- Coverage         6.78%   5.26%   -1.53%     
==============================================
  Files              676     143     -533     
  Lines           118955   21841   -97114     
==============================================
- Hits              8076    1149    -6927     
+ Misses          110267   20613   -89654     
+ Partials           612      79     -533     
Flag Coverage Δ
#aFlag 5.26% <0.00%> (-1.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cloudcommon/db/db_dispatcher.go 0.00% <0.00%> (ø)
pkg/cloudcommon/db/domain.go 3.48% <0.00%> (-0.09%) ⬇️
pkg/cloudcommon/db/domainresource.go 0.00% <0.00%> (ø)
pkg/cloudcommon/db/external.go 0.00% <0.00%> (ø)
pkg/cloudcommon/db/infraresource.go 0.00% <0.00%> (ø)
pkg/cloudcommon/db/managed.go 0.00% <ø> (ø)
pkg/cloudcommon/db/modelbase.go 4.77% <0.00%> (-0.04%) ⬇️
pkg/cloudcommon/db/opslog.go 1.52% <0.00%> (+0.03%) ⬆️
pkg/cloudcommon/db/rbac.go 1.16% <0.00%> (-0.02%) ⬇️
pkg/cloudcommon/db/sharablebase.go 6.81% <0.00%> (-0.28%) ⬇️
... and 462 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88497da...c93952d. Read the comment docs.

@swordqiu
Copy link
Member

swordqiu commented Aug 1, 2020

/lgtm

@swordqiu
Copy link
Member

swordqiu commented Aug 1, 2020

/approve

@yunion-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swordqiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yunion-ci-robot yunion-ci-robot merged commit 381a279 into yunionio:release/3.3 Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants