Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #7677: vpcagent: respect guest src check settings #7679

Conversation

yousong
Copy link
Contributor

@yousong yousong commented Aug 31, 2020

Cherry pick of #7677 on release/3.3.

#7677: vpcagent: respect guest src check settings

  mac   ip    dhcp    ping    xipping    xmacping
  on    on    y       y       n          n
  on    off   y       y       y          n
  off   off   y       y       y          y

external access depends on source routing, changing ip address will
fail that

note dst mac address of reply packet when changing only mac address
with vpc ip remains the same
@zexi
Copy link
Member

zexi commented Aug 31, 2020

/lgtm
/approve

@yunion-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zexi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yunion-ci-robot yunion-ci-robot merged commit 3268e59 into yunionio:release/3.3 Aug 31, 2020
@yousong yousong deleted the automated-cherry-pick-of-#7677-upstream-release-3.3 branch December 6, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants