Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with "outdated" conversations #1088

Closed
tiltec opened this issue Aug 26, 2018 · 2 comments · Fixed by karrot-dev/karrot-backend#635 or #1243
Closed

Deal with "outdated" conversations #1088

tiltec opened this issue Aug 26, 2018 · 2 comments · Fixed by karrot-dev/karrot-backend#635 or #1243
Assignees

Comments

@tiltec
Copy link
Member

tiltec commented Aug 26, 2018

Pickup and application conversations currently stay around forever, although the conversation target has an end. Especially in the case of application conversations it can be confusing if people reply to an application that already has been decided.

My proposal would be to close application and pickup conversations a few hours after the conversation target has ended. We would need to show information to the user about this behavior.

The alternative could be to close the conversation some hours after the last reply, to not cut off an active discussion.

@nicksellen
Copy link
Member

Ah the alternative idea sounds possibly like a smart way of dealing with it, it would need both criteria being fulfilled:

  1. the target has "ended" (whatever that means for the target)
  2. x hours has passed since last reply

If only 1) was implemented it will still check x hours since the target has ended, so adding 2) is not much more (referencing the time to the last reply rather than the target).

@tiltec
Copy link
Member Author

tiltec commented Jan 25, 2019

I would add an ended property to conversation targets and search for ended targets in a cronjob. If the last reply was more than 7 days ago, mark the conversation as "closed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants