Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversations to individual pickups #677

Closed
nicksellen opened this issue Oct 30, 2017 · 8 comments
Closed

Add conversations to individual pickups #677

nicksellen opened this issue Oct 30, 2017 · 8 comments
Assignees

Comments

@nicksellen
Copy link
Member

@nicksellen nicksellen commented Oct 30, 2017

No description provided.

@tiltec

This comment has been minimized.

Copy link
Member

@tiltec tiltec commented Mar 14, 2018

This seems relevant because people requested a feature where they can notify their group about spontaneous cancellation of pickups. To fulfill this, the pickup conversations should be readable and writable by all group members, but only pickup collectors should be notified by default about new messages.

@tiltec

This comment has been minimized.

Copy link
Member

@tiltec tiltec commented May 30, 2018

Bruno from Solikyl requested this feature recently:

We have pickups when we need more intense communication and that is unfortunately not available yet on Karrot, for example when we have big pickups and need to coordinate people loading cars in one place and people helping offload in other places, or when we have spontaneous pickups that require quick action. For now it's usually one of us calling around, but I know you have discussed features like conversations for the pickups. That, combined with push notifications, might do the job in the future. I just wanted to bring to your attention that this is a much needed feature at Solikyl and probably in any other foodsaving collective that is growing in size and activity.

@nicksellen

This comment has been minimized.

Copy link
Member Author

@nicksellen nicksellen commented Jun 10, 2018

Ok, I added a backend implementation. The frontend is a much bigger topic though. It might make sense to built it on top of #855. Or maybe not.

@tiltec

This comment has been minimized.

Copy link
Member

@tiltec tiltec commented Jun 10, 2018

Cool! I'd like to have that Slack-style interface for this (#683 ). #855 seems also nice, but I don't like the chat floater so much (and it's a desktop-only optimization, whereas karrot should maybe get more mobile focused).

@nicksellen

This comment has been minimized.

Copy link
Member Author

@nicksellen nicksellen commented Jun 10, 2018

So it might be a sidebar thing like the slack thread UI will work well here. On desktop it would sort of sit over the top, and on mobile be a full page.

@nicksellen

This comment has been minimized.

Copy link
Member Author

@nicksellen nicksellen commented Jun 10, 2018

Here's a quick idea. It's the existing <Conversation> component (reversed) put inside a <QLayoutDrawer> on the right:

pickupchat

@nicksellen

This comment has been minimized.

Copy link
Member Author

@nicksellen nicksellen commented Jun 14, 2018

[edit: moved to PR thread...]

@tiltec

This comment has been minimized.

Copy link
Member

@tiltec tiltec commented Jun 27, 2018

Done :)

@tiltec tiltec closed this Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.