Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: social 无法被覆盖,配置变得异常 #208

Closed
hairyf opened this issue Apr 6, 2023 · 6 comments
Closed

bug: social 无法被覆盖,配置变得异常 #208

hairyf opened this issue Apr 6, 2023 · 6 comments

Comments

@hairyf
Copy link
Contributor

hairyf commented Apr 6, 2023

配置:

image

结果:

image

与 yun siteCofng 合并 social

期望:

demo/valaxy.config.ts 中数组配置应该覆盖默认配置,或者说不应该存在默认的 siteConfig 配置

复现:

https://github.com/TuiMao233/valaxy-theme-hairy/tree/next

@YunYouJun
Copy link
Owner

目前并不存在默认的 social 配置。

@hairyf
Copy link
Contributor Author

hairyf commented Apr 7, 2023

那应该怎么解释这个情况,目前 social 有两份,另一位是 yun siteConfig 的,一份是我配置的,如何解释 yun siteCofng 中 social 会和用户配置并存

@hairyf hairyf changed the title bug: social 无法被覆盖,被默认配置合并 bug: social 无法被覆盖,配置变得异常 Apr 7, 2023
@hairyf
Copy link
Contributor Author

hairyf commented Apr 7, 2023

知道问题了,site.config.ts 配置与 valaxy.config.ts 配置合并导致,如果这是合理的,可以关闭掉这个问题

@YunYouJun
Copy link
Owner

site.config.tsvalaxy.config.ts 中的 siteConfig 只保留一份。

目前你是只在用户目录进行配置对吗?那样的话,我认为是合理的。

@hairyf hairyf closed this as completed Apr 11, 2023
@hairyf hairyf reopened this Apr 11, 2023
@hairyf
Copy link
Contributor Author

hairyf commented Apr 11, 2023

并不是,我在 valaxy.config.ts 中定义 siteConfig,后 social 与 site.config.ts 合并

再此重新打开这个问题

@YunYouJun
Copy link
Owner

valaxy.config.ts 中的 siteConfigsite.config.ts 的作用时相同的,只需要有一处存在。

目前的策略会将 site.config.ts 中的配置合并进 valaxy.config.ts 中的 siteConfig 中。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants