Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing variants in light::SoftwareUpdateState #1

Open
nn1ks opened this issue Apr 22, 2020 · 5 comments
Open

Missing variants in light::SoftwareUpdateState #1

nn1ks opened this issue Apr 22, 2020 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@nn1ks
Copy link
Owner

nn1ks commented Apr 22, 2020

Some variants in the light::SoftwareUpdateState enum are missing due to incomplete documentation in the Lights API. This can prevent deserialization of Light and return a ParseJson error.
@nn1ks nn1ks added bug Something isn't working help wanted Extra attention is needed labels Apr 22, 2020
@deckarep
Copy link
Contributor

I found a case: we need ReadyToInstall

deckarep added a commit to deckarep/huelib-rs that referenced this issue Jun 28, 2020
@deckarep
Adds new light ReadyToInstall variant - this is preventing deserializ…
d46e986 
…aiton.

I'm unable to deserialize due to this state which is missing for the SoftwareUpdateState enum.

Relevant error:

```
Failed to get lights: Failed to parse json content: unknown variant `readytoinstall`, expected `noupdates` or `notupdatable`
```

nn1ks#1
@deckarep deckarep mentioned this issue Jun 28, 2020
Merged
@nn1ks
Copy link
Owner Author

nn1ks commented Jun 28, 2020

Thanks @deckarep! I merged your PR and it's now available in version 0.8.0. I will leave this issue open in case there are other missing variants.

@deckarep
Copy link
Contributor

Great!, thank you...i also just opened a PR for huectl to pin against version 0.8.0 which I think needs to be updated.

@demerzel3
Copy link
Contributor

@Yuqio found another one: "transferring". Opened a PR for it 🙂

@nn1ks
Copy link
Owner Author

nn1ks commented Jul 24, 2020

Thanks @demerzel3! Your fix is available in version 0.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deckarep @demerzel3 @nn1ks