Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add better error handling for publish command #4

Closed
yusefnapora opened this issue Sep 19, 2022 · 0 comments · Fixed by #23
Closed

add better error handling for publish command #4

yusefnapora opened this issue Sep 19, 2022 · 0 comments · Fixed by #23

Comments

@yusefnapora
Copy link
Owner

Since updating a record requires incrementing the sequence number, and because I didn't want to make you keep old revisions around on disk, the publish CLI command fetches the latest value and increments the sequence number if it exists.

At the moment, we're treating all publish errors as if they were "name not found" and falling back to creating a new "v0" revision. We should only do that if we get a 404 back from the API, and bail out on other errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant