Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify commit messages using regexp-based rules (same as Gerrit's commentlink) #16

Closed
GoogleCodeExporter opened this issue Nov 10, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Gerrit has a way to configure regexp-based rules to create links in commit 
messages (among others) based on patterns: 
http://gerrit-documentation.googlecode.com/svn/Documentation/2.5.1/config-gerrit
.html#_a_id_commentlink_a_section_commentlink

If would be great if Gitiles had such capability too, so that we could have the 
same links in both Gerrit (on gwt-review.googlesource.com for instance) and 
Gitiles (at gwt.googlesource.com)

Even minimal support for linking to issues and other revisions, with hard-coded 
patterns, as is possible on Google Code Hosting, would be appreciated.

Original issue reported on code.google.com by t.broyer on 20 Dec 2012 at 2:32

@GoogleCodeExporter
Copy link
Author

FYI, there is currently limited support for Gerrit Change-Ids in 
com.google.gitiles.Linkifier, as you may have noticed. I agree it would be nice 
to support the same arbitrary linkification config as Gerrit. Ideally we would 
extract this out of Gerrit so it could be reused, rather than reimplementing it 
from scratch in Gitiles.

Original comment by dborowitz@google.com on 22 Dec 2012 at 10:18

@GoogleCodeExporter
Copy link
Author

I've started implementing this one.



Original comment by sbel...@google.com on 3 Nov 2014 at 5:35

@GoogleCodeExporter
Copy link
Author

https://gerrit-review.googlesource.com/61300

Original comment by jrn@google.com on 14 Nov 2014 at 6:27

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant