feat: add uri scheme for opening timer by opening a link #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olastor
commented
Jul 3, 2022
| import android.content.Intent | ||
| import android.content.IntentFilter | ||
| import android.content.SharedPreferences | ||
| import android.content.* |
There was a problem hiding this comment.
The IDE changed this, is the wildcard import a problem?
There was a problem hiding this comment.
It seems for some people this is important, I don't care either way
olastor
changed the title
tzugen
reviewed
Jul 3, 2022
| } | ||
|
|
||
| for (timeStr in data.getQueryParameter("times")!!.split(",").toTypedArray()) { | ||
| val time = Integer.valueOf(timeStr) |
There was a problem hiding this comment.
Have you tested what happens
- when
times=(empty param) - when
times=, - when
times=@€(@,€(
There was a problem hiding this comment.
No, good point... The last two raise an unhandled error. I've added a try/catch and a check whether the timer list is empty after parsing.
|
Merged, thank you! |
|
ah, forgot, could you add a short note to the readme to document this feature? Otherwise it will be very hidden. |
sure, added in #80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #15
@tzugen can you please take a look?
link scheme is like this:
bodhi://timer?times=60,120(will start a 1 minute and a two minute timer)Pausing does not work properly, but I think that is not necessary to support initially.