Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alarm ding when notifications pop up #1

Closed
Kintok1 opened this issue Nov 10, 2015 · 7 comments
Closed

Alarm ding when notifications pop up #1

Kintok1 opened this issue Nov 10, 2015 · 7 comments

Comments

@Kintok1
Copy link

Kintok1 commented Nov 10, 2015

This was already in 3.X.X versions, but has been lost for 4.X.X ones.

Would it be possible to bring that back? Or maybe add a custom alarm feature?

@Yuubari
Copy link
Owner

Yuubari commented Nov 10, 2015

It's not in the original KCV so it has to be re-implemented.

Moreover, the original implementation has some very bad design decisions related to “different sounds for different types of notifications” and I'm unsure whether these can be rectified.

@Yuubari
Copy link
Owner

Yuubari commented Nov 11, 2015

Update on this: will probably be ready soon as an additional plug-in. It will only implement sound notifications, with “visible” tray/toast stuff provided by the original plug-in.

@Kintok1
Copy link
Author

Kintok1 commented Nov 11, 2015

Good to know, looking forward to it.

@Yuubari
Copy link
Owner

Yuubari commented Nov 12, 2015

It's basically ready but there's one issue: I don't remember whether the notification sound in 3.x ever overrode KCV's “mute audio” function.

I've implemented audio output part of the new plug-in with the exact same library and the exact same code, but it gets muted when KCV is muted. Is it the same on 3.x?

@Yuubari
Copy link
Owner

Yuubari commented Nov 12, 2015

Feel free to test it out: AudibleNotifications 1.0. You have to configure it via Settings, Plugins, AudibleNotifications Settings (the small link in the Features line).

Note that as mentioned above, if you mute KCV using the mute button custom sounds will not play, however the default Windows ding will (when no custom sounds are found).

@Kintok1
Copy link
Author

Kintok1 commented Nov 13, 2015

Haven't tested the custom ones, but the Windows ding works correctly like it used to, thanks!

As a note, the notifications in 3.x releases did play the Windows ding even if the game was muted by KCV's mute button.

@Yuubari
Copy link
Owner

Yuubari commented Nov 13, 2015

Because it's the way life's meant to be.

The ding is generated in the system notifications audio session which is system-wide and independent from application audio sessions like KCV's. Sadly, there is no way to access this audio session to play arbitrary audio streams aside from using a very old API call (PlaySound) that only supports 16-bit PCM RIFF WAVE files and has some issues, too.

This plug-in will be included with KCV, starting with next build.

@Yuubari Yuubari closed this as completed Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants