Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/docs: add release workflow (publish to pypi) and a RELEASE.md file #32

Merged
merged 2 commits into from Feb 7, 2023

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Sep 3, 2022

PR Summary

  • The github secret PYPI_PASSWORD is added already, based on a deployment token for our PyPI bot account now with maintainer permissions for the associated PyPI project.
  • Added a copy/pasted/tweaked RELEASE.md based on this workflow of relying on the github CI system to do upload to PyPI.

Related

It would be nice to retroactively add tags to the commits associated with the previous releases and push those before merging this to avoid triggering workflows that would try publish to PyPI. If that is done later, they won't override any PyPI release though because the upload command looks like this: twine upload --skip-existing dist/*

@consideRatio consideRatio changed the title ci: add release workflow (publish to pypi) ci/docs: add release workflow (publish to pypi) and a RELEASE.md file Sep 4, 2022
@yuvipanda
Copy link
Collaborator

Is there something I should do to move this forward? :D

@consideRatio
Copy link
Member Author

Review merge :)

@yuvipanda yuvipanda merged commit f145734 into jupyterhub:main Feb 7, 2023
@yuvipanda
Copy link
Collaborator

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants