Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for JupyterLab 3, Router, Settings, etc. #14

Merged
merged 63 commits into from Jan 31, 2021

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Jan 18, 2021

Sorry for the monster PR.

Binder

References:

Changes:

  • supports JupyterLab
    • this eschews jupyter-packaging and build-system with some simpler stuff...
      • i don't like npm stuff running inside of pip install, much less webpack
  • reworks the package metadata
    • the only version number is package.json/version
  • reworks CI
    • build the whl, tar.gz and tgz in one linux job, add a SHA256SUM file
    • test against a matrix vs installing the .whl or .tar.gz
    • still building the npm tarball because...
  • hoists the Meet instance to a new VideoChatManager exposed as the token that other plugins can use in activate
    • this will allow other extensions to do... things with the current Meeting. Not sure what, but i'm excited about:
  • adds settings for
    • user display name and email
    • configOverwrite (adds disableThirdPartyRequests to defaults)
    • interfaceConfigOverwrite (also hides the google/office 365 extension banner)
    • hiding public room UI (true by default)
  • allows for creating public rooms
  • reworks the DOM structure some, especially on the room list
    • tries to use more accessible/semantic HTML, remove lots of classes
    • some icons
  • loads external_api.js directly from the jitsi domain (via gross <script> injection, but what can you do) instead of bundling

Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions on compatibility between notebook & jupyter_server packages. But otherwise - I don't think I've the capability to CR the labextension, so I'll just merge it since you're cool & awesome :)

@bollwyvl
Copy link
Collaborator Author

questions on compatibility between notebook & jupyter_server packages

What's the flavor of concern? The nbclassic route works... but I don't know for how long. I could see issues arising prior to the hard cut at lab 4.x, but haven't been keeping track of the various lifecycle pieces.

A thing I'd really like to see is this working with voila (likely as a separate package), which is already jupyter_server-only.

As for integration with other UIs... I don't think the design constraints of jupyterlab-classic lend itself very well to this extension, as a dialog would be extremely unsatisfying, and if you start slamming more dom in the page... that might be resizable... and tabbed... well, sure sound like Lab at that point.

CR the labextension

Yeah, we had some events to run and needed some of the capability, so that initial PR kinda just kept going. Of course, shame on me for not having added better tests, but Always Be Demoing...

A follow-on could raise the browser testing game some... it would crack me up to have different CI bots talking to each other on Jitsi during CI

LINUX 3.9:     YO, WINDOWS, YOUR FILESYSTEM SO FAT, IT NEEDS 128 BITS
WINDOWS 3.6:   *CRIES*
MACOS 3.9:     BURN.

just merge it

cool, appreciated. I'll do another look over it, and re-request review... doing the binder shakedown i noticed some stuff, as it's the only hub-like-thing i have to test open source stuff. If you had any notes from it (not) working in your required hub setup, that would be rad. You can grab the tarballs from the dist asset.

@bollwyvl
Copy link
Collaborator Author

Alright, there are still some lingering issues with restoring a particular video chat after refreshing the browser... I think i messed up the commands somehow. Otherwise, shook down everything I found that was bothering me. I guess give it a spin and let me know what's missing from a functionality perspective. While working on it, had some ideas I'll hoist to follow-on issues.

@bollwyvl
Copy link
Collaborator Author

@yuvipanda thoughts?

@yuvipanda yuvipanda merged commit 3dbb06c into jupyterlab-contrib:master Jan 31, 2021
@yuvipanda
Copy link
Collaborator

@bollwyvl I've hit the merge button :D Will you be able to do appropriate releases? <3

@bollwyvl
Copy link
Collaborator Author

😻 on it. I'll start a release ticket, and start shaking it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterLab 3.0 support Add lab router link? Consider switching to main area widget
2 participants