Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full URLs to support multiple repository providers #17

Open
jmunroe opened this issue Mar 15, 2024 · 1 comment
Open

Allow full URLs to support multiple repository providers #17

jmunroe opened this issue Mar 15, 2024 · 1 comment

Comments

@jmunroe
Copy link

jmunroe commented Mar 15, 2024

Current the form assumes that the 'GitHub Repository' will be specified as the repo name only but users may assume the full URL is required:

Could not resolve ref for gh:https://github.com/binder-examples/conda/HEAD. Double check your URL and that your repo is public. GitHub recently changed default branches from "master" to "main".

image_720

The GitHub repository binder-examples/conda works as expected.

image_720

Since the Binder API already supports multiple repository provides, let's generalize the behavior so that GitHub repos are not an explicit requirement.

@jmunroe
Copy link
Author

jmunroe commented Mar 15, 2024

@yuvipanda -- I am not an owner on this repo but could you assign me this one? I like to give a shot at fixing it. (Good practice for all of those JS/React tutorials I worked through previously but don't get much of a chance to use at the moment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant