Switch to Non-Maven Jar plugin to vendor jars #206

stephenc · 2020-05-05T09:38:03Z

This enables anyone to checkout and build the project without having to mess around with installing jar files

NOTE: I know when I wrote the non-maven jar maven plugin I included a warning about "use of the plugin acknowledging bad citizen, etc" but that is more reflecting that we (The Apache Maven PMC) want to nudge people towards publishing on Central... which is also why I published the plugin from my personal account rather than releasing it from the Apache Maven project itself. However, compared to what you were doing with the lib folders, this is - as a member of the Apache Maven PMC - an improvement.

- This enables anyone to checkout and build the project without having to mess around with installing jar files

stephenc · 2020-05-05T09:38:31Z

Here's the details on the plugin I wrote a while back: https://github.com/stephenc/non-maven-jar-maven-plugin

ggrossetie · 2020-05-05T12:28:44Z

Thanks @stephenc !
For reference, on another project, I ended up creating a local maven repository with mvn install:install-file.

mvn install:install-file -Dfile=src/main/lib/bigquery-jdbc/error_prone_annotations-2.1.3.jar -DgroupId=org.jdbc.bigquery -DartifactId=error_prone_annotations -Dversion=2.1.3 -Dpackaging=jar -DlocalRepositoryPath=src/main/lib -DcreateChecksum=true

And then, I added the local repository in my pom.xml:

<repository>
  <id>lib</id>
  <url>file://${project.basedir}/lib</url>
</repository>

It's a bit hacky because you have to commit a local maven repository but it's working... 😬
Out of curiosity, what is your opinion on this solution?

However, compared to what you were doing with the lib folders, this is - as a member of the Apache Maven PMC - an improvement.

It's definitely an improvement, and the changes are minimal so 👍

stephenc · 2020-05-05T14:38:02Z

<repository>
  <id>lib</id>
  <url>file://${project.basedir}/lib</url>
</repository>

is also bad because most corporate users will have <mirrorOf>*</mirrorOf> in their settings.xml so that will nor work for them either. Hence why non-maven-jav is the least worst solution if you cannot get them into central

ggrossetie · 2020-05-05T18:35:28Z

server/pom.xml

      <artifactId>ditaa</artifactId>
-      <version>${ditaa.version}</version>
+      <version>${project.version}</version>


Is it possible to keep the version of the jar? If not I guess that we can safely remove the reference in the <properties> right?

Not if you want to use the Maven release tooling...

I'm pretty sure there's a good reason but I'm not sure I understand why... we are using a "released" version no? Sorry, I'm sure I'm not using the correct terminology but I would expect this dependency to be resolved as a "standard" dependency.
But I guess the thirdparty/ditaa/pom.xml is not really the pom of the dependency but the pom of the project that contains a jar. So we cannot define <version>1.3.13</version> in thirdparty/ditaa/pom.xml and use it in here?

Anyway, I think it's fine, I'm mainly asking to learn 🤓

Once you get the release plugin automating the version number bumps you’ll need all the poms to align their version number.

If you’re not using a release plugin and not using -SNAPSHOT versions on master then you could have different versions

thirdparty/ditaa-mini/pom.xml

stephenc · 2020-05-06T10:17:56Z

Anything blocking merging this?

ggrossetie · 2020-05-06T13:50:18Z

Anything blocking merging this?

@stephenc No it's looking good but I want to checkout the branch locally and play with it before merging 😄

stephenc · 2020-05-06T14:22:02Z

For some IDEs you may need to use mvn install to have the 3rd party vendored libraries available in the IDE

ggrossetie

Thanks again, it's working just fine 👌

ggrossetie · 2020-05-09T18:08:35Z

For some IDEs you may need to use mvn install to have the 3rd party vendored libraries available in the IDE

@stephenc I spoke too soon, it's not working on Intellij IDEA... even if I do mvn install. Not sure what to do, but if it's not working I might revert this commit because that's a pretty big issue 😞

Edit: Manually adding the dependency on "Project Structure..." works but not ideal. The dependencies look fine but it looks like the non-maven jars are ignored by Intellij.

stephenc · 2020-05-09T18:44:29Z

Strange. Works for me in IntelliJ. I’ll wipe my cache and try again

ggrossetie · 2020-05-09T20:23:23Z

Very strange indeed... I'm using:

IntelliJ IDEA 2019.3.4 (Ultimate Edition)
Build #IU-193.6911.18, built on March 17, 2020
Runtime version: 11.0.6+8-b520.43 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.15.0-99-generic
GC: ParNew, ConcurrentMarkSweep
Memory: 1981M
Cores: 8
Registry: 
Non-Bundled Plugins: BashSupport, Batch Scripts Support, CMD Support, CheckStyle-IDEA, FindBugs-IDEA, JFormDesigner, com.intellij.ideolog, com.wix.eslint, org.asciidoctor.intellij.asciidoc, org.jetbrains.idea.grammar

I will try with the latest version...

ggrossetie · 2020-05-10T07:56:29Z

@stephenc could you please confirm that it's working fine after the cache has been wiped? If so, could you please copy/paste your Intellij version? Thanks!

stephenc · 2020-05-10T10:24:38Z

@Mogztter I am sorry, IntelliJ seems to have taken a step back in how they parse Maven project models. I may need to rework some hacks into the non-maven jar. For now just revert this commit and I'll re-submit the PR once I find some way to get IDEA working again...

The TL;DR https://youtrack.jetbrains.com/issue/IDEA-175538 is probably the issue here

stephenc · 2020-05-10T10:26:38Z

When I reported https://youtrack.jetbrains.com/issue/IDEA-175538 everything worked in IDEA as long as you didn't add <type>non-maven-jar</type> to your dependencies... and that bug was about supporting the custom type... seems now they broke things even more that not even the default implicit <type>jar</type> works any more

stephenc · 2020-05-10T10:29:32Z

A workaround is to run mvn install and then open only server/pom.xml in IDEA as that will force it not to see these side projects and resolve from the maven repo

stephenc · 2020-05-10T10:30:12Z

Oooooh.... we could have a profile that is active unless maven is being parsed by intellij... that profile could add the 3rd party jar files

stephenc · 2020-05-10T10:39:59Z

Something like

  <profiles>
    <profile>
      <id>hide-thirdparty-modules-from-IDEA</id>
      <activation>
        <property>
          <name>!idea.version</name>
        </property>
      </activation>
      <modules>
        <module>thirdparty</module>
      </modules>
    </profile>
  </profiles>

Though IDEA seems not to be correctly parsing profile activation either and is incorrectly enabling that profile... But at least putting third party in a profile allows you to deactivate the profile and get IDEA working again (after mvn install)

stephenc · 2020-05-10T10:41:49Z

Ok IDEA's pom parsing no longer exposes idea.version.... may need a new trick to detect IDEA's pom parser... I'll get during the week

ggrossetie · 2020-05-10T10:49:13Z

Damn!

Though IDEA seems not to be correctly parsing profile activation either and is incorrectly enabling that profile... But at least putting third party in a profile allows you to deactivate the profile and get IDEA working again (after mvn install)

That could work!
I'm fine with the initial mvn install.

For now just revert this commit and I'll re-submit the PR once I find some way to get IDEA working again...

Ok.

Switch to Non-Maven Jar plugin to vendor jars

910e23d

- This enables anyone to checkout and build the project without having to mess around with installing jar files

Remove redundant installs

f56b8d2

ggrossetie reviewed May 5, 2020

View reviewed changes

thirdparty/ditaa-mini/pom.xml Show resolved Hide resolved

Remove ditaa versions

5151e62

ggrossetie approved these changes May 6, 2020

View reviewed changes

ggrossetie merged commit 71232f0 into yuzutech:master May 6, 2020

ggrossetie mentioned this pull request May 10, 2020

Revert "Switch to Non-Maven Jar plugin to vendor jars" #214

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to Non-Maven Jar plugin to vendor jars #206

Switch to Non-Maven Jar plugin to vendor jars #206

stephenc commented May 5, 2020

stephenc commented May 5, 2020

ggrossetie commented May 5, 2020

stephenc commented May 5, 2020

ggrossetie May 5, 2020 •

edited

stephenc May 5, 2020

ggrossetie May 5, 2020

stephenc May 6, 2020

stephenc commented May 6, 2020

ggrossetie commented May 6, 2020

stephenc commented May 6, 2020

ggrossetie left a comment

ggrossetie commented May 9, 2020 •

edited

stephenc commented May 9, 2020

ggrossetie commented May 9, 2020

ggrossetie commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

ggrossetie commented May 10, 2020

Switch to Non-Maven Jar plugin to vendor jars #206

Switch to Non-Maven Jar plugin to vendor jars #206

Conversation

stephenc commented May 5, 2020

stephenc commented May 5, 2020

ggrossetie commented May 5, 2020

stephenc commented May 5, 2020

ggrossetie May 5, 2020 • edited

Choose a reason for hiding this comment

stephenc May 5, 2020

Choose a reason for hiding this comment

ggrossetie May 5, 2020

Choose a reason for hiding this comment

stephenc May 6, 2020

Choose a reason for hiding this comment

stephenc commented May 6, 2020

ggrossetie commented May 6, 2020

stephenc commented May 6, 2020

ggrossetie left a comment

Choose a reason for hiding this comment

ggrossetie commented May 9, 2020 • edited

stephenc commented May 9, 2020

ggrossetie commented May 9, 2020

ggrossetie commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

stephenc commented May 10, 2020

ggrossetie commented May 10, 2020

ggrossetie May 5, 2020 •

edited

ggrossetie commented May 9, 2020 •

edited