Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable connect function #163

Open
ywangd opened this issue Nov 22, 2020 · 1 comment
Open

Configurable connect function #163

ywangd opened this issue Nov 22, 2020 · 1 comment
Labels
question Further information is requested

Comments

@ywangd
Copy link
Owner

ywangd commented Nov 22, 2020

The connect function does all the things that are required for connection itself. However there could be other things around it which could be customised, e.g. execute a command/script after a connection is created. This particular feature is implemented with a callback (#160). However there are variations which make it too much to implement, e.g. execute a command/script before a connection is created.

It is already possible to define a custom function that does what connect does and more. This new function can be used in place of connect function after the peek is launched. However, at launch time, the connect function is used internally to create the default connection and this is not replacable. Do we want to allow it to be replaced? Or is it sufficient if #162 is implemented?

@ywangd ywangd added the question Further information is requested label Nov 22, 2020
@ywangd ywangd closed this as completed in 9089e5f Nov 22, 2020
@ywangd
Copy link
Owner Author

ywangd commented Nov 23, 2020

Accidentally closed. Reopen.

@ywangd ywangd reopened this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant