Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for launching specified editor in the process ? #15

Closed
Orange-C opened this issue Jul 6, 2019 · 4 comments
Closed

Support for launching specified editor in the process ? #15

Orange-C opened this issue Jul 6, 2019 · 4 comments

Comments

@Orange-C
Copy link

Orange-C commented Jul 6, 2019

For some people who don't use command line tools for editor.

I already created launch-code-editor to temporarily solve my case

I'll be appreciated if launch-editor is interested in supporting this feature. I'll create a PR when needed.

@Orange-C Orange-C changed the title Support for launching the editor in the process ? Support for launching specified editor in the process ? Jul 6, 2019
@chrisfromredfin
Copy link

+1 on this. I would like either (a) to be able to specify the preference / order to try the applications in, or (b) be able to have it respect EDITOR if set FIRST, and THEN fall back to guessing from running apps.

My particular case is that I often run Sublime Text and VS Code for two different reasons (and prefer VS Code as the code editor), but since VS Code appears later in the osx.js it opens in Sublime instead of VS Code as that's the first one it finds.

I wonder if in the package.json I could specify the order as it was specified in, say, osx.js and it would read that and then fall back to the default file if not found?

I also see that you're fundamentally doing the same by checking process.versions.webcontainer, and I wonder if I could somehow specify process.versions.webcontainer TRUE somewhere on my own, but I can't find anything about how to SET process.versions, only how to read it.

@chrisfromredfin
Copy link

Alternatively, something like being able to specify "forceEditor": TRUE and then the line becomes:

if (process.versions.webcontainer || forceEditor) {...}

@dominikg
Copy link
Contributor

dominikg commented Jun 9, 2022

maybe fixed by #39

@sodatea
Copy link
Collaborator

sodatea commented Aug 20, 2022

Released as 2.6.0

@sodatea sodatea closed this as completed Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants