TOC extension not working on Convert Markdown to PDF

[ezequias]

I can't see links working on a generated pdf from markdown to pdf extension. TOC extension is working on default markdown preview on VSCode.

• VSCode Version: 1.15.1
• OS Version: Windows 10

Steps to Reproduce:

1. Write a nice markdown text (with many #, ## and ###)
2. Enable TOC on Markdown (with Markdown TOC extension)
3. Convert Markdown to PDF (with Markdown to PDF extension)

If you have any plans to solve this reporting please tell me.

[dio833]

Hello

I convert md to html file with Markdown PDF then trace html code.

I see the tag <h1-6> doesn't has ID attribute. So Anchors can't work.

Could you keep the ID attribute of <h1-6> tag ?

Thanks.

[ezequias]

@dio833 I didn't understand you. How did you convert md to html with Markdown PDF? Is it another extension? All my attributes are from h1 to h6 but I confess it has some spaces on links generated.

Would be nice if the extension only could create a hyperlink only about the first word of the markdown ID.

[dio833]

@ezequias
>user setting open youre user setting then find "markdown-pdf.type".

You can choose output format. such as "markdown-pdf.type": "html",.

In HTML source , all h1~h6 tags miss ID attribute. So Markdown TOC can't work well here.

You can add id into h1~h6 tags manually . or maybe @yzane can fix this issue.

[ezequias]

@dio833 nice tip. I like it! ;)

[coop333]

This is related to issue #6

[kkhrv]

As I see, using ID attributes is not enough to fix issue: phantomjs doesn't work well with internal links: ariya/phantomjs/issues/13959

[yzane]

I pre-released Markdown PDF ver1.0.0 which replaced pdf converter with puppeteer instead of html-pdf.
Please download from here and try.