Toggle checkbox keybinding no longer works in version 3.6.0 or newer

[joneshf-dd]

What's the problem

Toggle checkbox keybinding no longer works in version 3.6.0 or 3.6.1. This behavior works in 3.5.1.

What's the expected result

When pressing the toggle checkbox keybinding (Option+C on macOS by default), it should toggle the checkbox.

How to reproduce

1. Install 3.6.0 or 3.6.1.
2. Make a checkbox

   - [ ] Something

3. Press Option+C (or the equivalent).
4. It will not toggle the checkbox.

Other information

You can validate that it still works in 3.5.1 by downgrading the extension and running through the same reproduction steps.

[yzhang-gh]

Thanks for the feedback. I forgot to mention that this key binding was removed for Mac as it overrides a character in other languages (#1285). You can assign it back to the command markdown.extension.checkTaskList. This is also the case for markdown.extension.editing.toggleStrikethrough which had the key binding alt+s.

[xiecang]

My reassignment to Option+C doesn't seem to work, do I need to bind it to another shortcut?

[yzhang-gh]

You can use this method to check what VS Code is doing after you pressed the key binding.

[xiecang]

When I press option+C, I get this log:

2024-01-16 21:37:54.683 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-01-16 21:37:54.700 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-01-16 21:37:54.700 [info] [KeybindingService]: / Received keydown event - modifiers: [alt], code: AltLeft, keyCode: 18, key: Alt
2024-01-16 21:37:54.700 [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: AltLeft, keyCode: 6 ('Alt')
2024-01-16 21:37:54.700 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-01-16 21:37:55.007 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-01-16 21:37:55.007 [info] [KeybindingService]: | Resolving alt+[KeyC]
2024-01-16 21:37:55.007 [info] [KeybindingService]: \ No keybinding entries.
2024-01-16 21:37:55.007 [info] [KeybindingService]: / Received keydown event - modifiers: [alt], code: KeyC, keyCode: 67, key: ç
2024-01-16 21:37:55.008 [info] [KeybindingService]: | Converted keydown event - modifiers: [alt], code: KeyC, keyCode: 33 ('C')
2024-01-16 21:37:55.008 [info] [KeybindingService]: | Resolving alt+[KeyC]
2024-01-16 21:37:55.008 [info] [KeybindingService]: \ No keybinding entries.
2024-01-16 21:37:55.253 [info] [KeybindingService]: + Ignoring single modifier alt due to it being pressed together with other keys.

this is my shortcut configuration.

[yzhang-gh]

That is because you set when to false, which means never. Try e.g. (remove the !isMac condition)

vscode-markdown/package.json

Lines 315 to 317 in cfd568b

	"command": "markdown.extension.checkTaskList",
	"key": "alt+c",
	"when": "editorTextFocus && editorLangId =~ /^markdown$|^rmd$|^quarto$/ && !isMac"

[xiecang]

That is because you set when to false, which means never. Try e.g. (remove the !isMac condition)

vscode-markdown/package.json

Lines 315 to 317 in cfd568b

	"command": "markdown.extension.checkTaskList",
	"key": "alt+c",
	"when": "editorTextFocus && editorLangId =~ /^markdown$|^rmd$|^quarto$/ && !isMac"

Thank you so much, the changes worked perfectly following your configuration.

[joneshf-dd]

Thanks for the feedback. I forgot to mention that this key binding was removed for Mac as it overrides a character in other languages (#1285). You can assign it back to the command markdown.extension.checkTaskList. This is also the case for markdown.extension.editing.toggleStrikethrough which had the key binding alt+s.

I see. Any chance the extension itself could change the key binding to something else? I don't really care if I use Option+C or something else, but I'd like to not have to remember to override the keybinding for different macOS machines.

[Gorzas]

Not much experience using MacOS, but could be the key binding be Ctrl + c and Ctrl + s? Or maybe make it configurable per user.

[yzhang-gh]

Hi, sorry for the late reply. It is hard to find an easy-to-remember but not-yet-been-used key binding. (There are many issues in this repository complaining about the default key bindings.)

I'd like to not have to remember to override the keybinding for different macOS machines

@joneshf-dd I would suggest sync your settings/profiles with a GitHub account. VS Code had been developed/polished this feature for a long time and I feel it is easy to use.

Or maybe make it configurable per user

@Gorzas You can configure the key binding with VS Code's keyboard shortcuts editor (The commands are markdown.extension.checkTaskList and markdown.extension.editing.toggleStrikethrough). And again, it can be synced with an account.