COF Algorithm

[John-Almardeny]

All Submissions Basics:

Closes #7

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?
• Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
• Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

• Have you created a .py in ~/pyod/models/?
• Have you created a _example.py in ~/examples/?
• Have you created a test_.py in ~/pyod/test/?
• Have you lint your code locally prior to submission?

[coveralls]

Pull Request Test Coverage Report for Build 836

• 138 of 139 (99.28%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 94.939%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pyod/test/test_cof.py	96	97	98.97%

Totals
Change from base Build 832:	0.2%
Covered Lines:	3864
Relevant Lines:	4070

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 836

• 138 of 139 (99.28%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 94.939%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pyod/test/test_cof.py	96	97	98.97%

Totals
Change from base Build 832:	0.2%
Covered Lines:	3864
Relevant Lines:	4070

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 903

• 137 of 138 (99.28%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 95.501%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pyod/test/test_cof.py	96	97	98.97%

Totals
Change from base Build 901:	0.1%
Covered Lines:	3821
Relevant Lines:	4001

---

💛 - Coveralls

[John-Almardeny]

@yzhao062

Hi Yue,
I am happy with it now. Please check and merge.
Related issue: Implement Connectivity-based outlier factor (COF) #7
Thanks,
Yahya.

[yzhao062]

Hi Yahya,

By any chance could you make a new PR for the three files only?
cof.py, cof_example.py, and test_cof.py.

I mistakenly deleted requirements_ci.txt (which should not be touched) from this PR. Merging this may result in some difficulties. If so I could close one and work on the new PR.

Thanks.
Yue

[John-Almardeny]

Hi Yue,

I do not know why ya deleted the file. You should have compared it with development branch because they are the exact same :) Previously, I just needed pandas so I added it then I found a way to get rid of pandas, thus I reverted my action. As a result, there's no change to requirements_ci.txt at all.

I will copy it from development and push it again to the branch. So there should be no problem.

[John-Almardeny]

Hi Yue,
Now this PR is identical to your development branch except the 3 files ya mentioned.
Cheers :)

[John-Almardeny]

Hi Yue,

There is a problem in building your original development branch:

ModuleNotFoundError: No module named 'sklearn.externals.funcsigs'

It seems that python-sklearn package is not installed after doing the updates.

[yzhao062]

Thanks for implementing this model. It is merged now and will be out in V0.7.2. I will direct all COF related issues to you. I will also include it in benchmark and other visualization:) Thanks a lot for the patience!

Yue