Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomaly Detection Using Seasonal Hybrid Extreme Studentized Deviate Test + tidy #9

Closed
cneskey opened this issue Dec 7, 2019 · 1 comment

Comments

@cneskey
Copy link

cneskey commented Dec 7, 2019

https://github.com/hrbrmstr/AnomalyDetection/blob/master/README.md
Anomaly Detection Using Seasonal Hybrid Extreme Studentized Deviate Test

Twitterfolks launched this package in 2014. Many coding and package standards have changed. The package now conforms to CRAN standards.

The plots were nice and all but terribly unnecessary. The two core functions have been modified to only return tidy data frames (tibbles, actually). This makes it easier to chain them without having to deal with list element dereferencing.

Shorter, snake-case aliases have also been provided:

ad_ts for AnomalyDetectionTs
ad_vec for AnomalyDetectionVec

The original names are still in the package but the README and examples all use the newer, shorter versions.

The following outstanding PRs from the original repo are included:

Added in PR #98 (@gggodhwani)
Added in PR #93 (@nujnimka)
Added in PR #69 (@randakar)
Added in PR #44 (@nicolasmiller)
PR #92 (@caijun) inherently resolved

If those authors find this repo, please add yourselves to the DESCRIPTION as contirbutors.

@yzhao062
Copy link
Owner

yzhao062 commented Dec 8, 2019

Thanks for pointing this out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants