Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: LabCompass automatically get the json file? #48

Open
veenarm opened this issue Jun 28, 2018 · 4 comments
Open

Suggestion: LabCompass automatically get the json file? #48

veenarm opened this issue Jun 28, 2018 · 4 comments

Comments

@veenarm
Copy link

veenarm commented Jun 28, 2018

Rather than having to manually process the files, can the json be setup as a rest service or such on poelab and the application retrieve it itself and cache it?

@RectangleEquals
Copy link

RectangleEquals commented Sep 8, 2018

I completely agree with this!

Especially for newer players, It's such a hassle that a 3rd party tool requires you to go to navigate through a 3rd party website in order to download a file, and then you still need to tell the app where that file is on your PC. Why not just have the user choose between Normal/Cruel/Merciless/Eternal (Uber), and download the file to a local or temporary location? Qt is capable of HTTP, TCP and UDP network communication, so the bulk of the issue would be designing code that either scrapes HTML (and keeping that up to date), or some other means to obtaining direct links from poelab.

Since I have no idea what the relationship between the authors of poelab and the dev(s) of LabCompass is like, I can't really suggest the best route to take. All I can say is that it's possible now (via HTML scraping), and even easier (and more maintainable) if both parties had a secure TCP authentication system to bypass HTML parsing altogether, downloading the file directly without requiring an HTML link. Alternatively, if both poelab and LabCompass are the same entity, then perhaps the poelab website can supply a static url to a json file which serves as a "table of contents" for LabCompass to get all the info it needs.

@tamaroth
Copy link

I think an automatic download of the json file from www.poelab.com would overall hurt everybody.

In the short run, most users would be satisfied they do not have to each day manually download the file, but that would take away revenue (and therefore support) of the website itself, which, in the long run, could cause the website to close due to lack of funding (they rely on ad revenue and patreon support).

If poelab had a paid feature that would, for example, expose an API for the user that would allow automatic download of json files, it would be much different (and most likely much better for everyone involved).

As it is now, I highly doubt that the author would deprive poelab of their revenue. It's best to ask the lads over there for this kind of support.

@xmesaj2
Copy link

xmesaj2 commented Mar 24, 2019

I've contacted poelab.com guys with similar question, they do need visits to keep the website running, so this shouldn't be added if they provide notes for free basically.

@baterflyrity
Copy link

+1 to this feature. Btw, one can just fork or write wrapper around this tool with automatic download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants