Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy for downloading and streaming #221

Closed
4 tasks done
xmha97 opened this issue Sep 24, 2022 · 5 comments
Closed
4 tasks done

Proxy for downloading and streaming #221

xmha97 opened this issue Sep 24, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@xmha97
Copy link
Contributor

xmha97 commented Sep 24, 2022

Checklist

  • I am able to reproduce the bug with the latest version.
  • I've checked that there is no issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce the bug

  1. I open the app
  2. I set a proxy (because YouTube is blocked in my country)
  3. Content will load (but not stream or download)

Expected behavior

Apply proxy for streaming and downloading

Actual behavior

Proxy is not applied for streaming and downloading

Screenshots/Screen recordings

VID_20220924_152046_633.mp4

Logs

No response

Music version

0.4.1-stable

Android version

Android 12

Additional information

No response

@xmha97 xmha97 added the bug Something isn't working label Sep 24, 2022
@xmha97
Copy link
Contributor Author

xmha97 commented Sep 25, 2022

@z-huang Is it difficult to implement?

@z-huang
Copy link
Owner

z-huang commented Sep 26, 2022

Proxy for the player isn't too hard, but proxy for downloading is a bit tricky because Android DownloadManager doesn't have such option. I have to create a custom downloader. However, it also fixes #13.

@z-huang
Copy link
Owner

z-huang commented Oct 7, 2022

9ed1d50 should fix proxy for streaming.

@xmha97
Copy link
Contributor Author

xmha97 commented Oct 7, 2022

9ed1d50 should fix proxy for streaming.

Thanks.

@z-huang z-huang added enhancement New feature or request and removed bug Something isn't working labels Oct 9, 2022
@z-huang
Copy link
Owner

z-huang commented Jun 27, 2023

Since InnerTune now use ExoPlayer for both streaming and downloading, the issue is solved.

@z-huang z-huang closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants