HasMany JS Script BUG! Using multiple instance of hasMany works only one

[llxx-lord-xxll]

• Laravel Version: 5.5.40
• PHP Version:7.1.7
• Laravel-admin: 1.5.x-dev

Description:

I wanted to use the hasMany field with several forms in different tabs. But (New) was not working only the first instance. Also if i click new button to one form, it was acting weird ( Adding new fields to other forms too)

Steps To Reproduce:

By digging through the codes, i have found that the javascript code related to this was calling the element by ID. So i have changed some changes in Encore\Admin\Form\Field\HasMany class. It is now solved.

The edited lines are marked with > character.

    protected function setupScriptForDefaultView($templateScript)
    {
        $removeClass = NestedForm::REMOVE_FLAG_CLASS;
        $defaultKey = NestedForm::DEFAULT_KEY_NAME;

        /**
         * When add a new sub form, replace all element key in new sub form.
         *
         * @example comments[new___key__][title]  => comments[new_{index}][title]
         *
         * {count} is increment number of current sub form count.
         */
        $script = <<<EOT
var index = 0;

> $('.has-many-{$this->column}').on('click', '.add', function () {
> 
>     var tpl = $('template.{$this->column}-tpl');
> 
>     index++;
> 
>     var template = tpl.html().replace(/{$defaultKey}/g, index);
>     console.log($(this).parent().parent().parent());
>     $(this).parent().parent().parent().append(template);
>     //$('.has-many-{$this->column}-forms').append(template);
>     {$templateScript}
> });

$('.has-many-{$this->column}').on('click', '.remove', function () {

>     $(this).closest('.has-many-{$this->column}-form').hide();
>     $(this).closest('.has-many-{$this->column}-form').find('.$removeClass').val(1);

});

EOT;

        Admin::script($script);
    }

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mRamadan0101]

this not working fine
i have issue when edit form and add new first one is removed