Skip to content
This repository has been archived by the owner on May 16, 2022. It is now read-only.

feat: support aspectRatio #195

Merged
merged 2 commits into from
May 16, 2021
Merged

feat: support aspectRatio #195

merged 2 commits into from
May 16, 2021

Conversation

branikclimbs
Copy link
Contributor

@branikclimbs branikclimbs commented May 12, 2021 •
edited

I added support for aspecRatio so e.g.:aspect-1/1 is now possible

z0al
z0al approved these changes May 13, 2021
View reviewed changes
Copy link
Owner

@z0al z0al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you so much for taking the time to contribute 🙇🏻

Left one question about the chosen values for the default theme.

src/lib/theme/base.ts Outdated Show resolved Hide resolved
@z0al
Copy link
Owner

z0al commented May 13, 2021

Tip: You need to run jest -u to update the snapshots

@z0al z0al merged commit d036a1a into z0al:master May 16, 2021
@z0al
Copy link
Owner

z0al commented May 16, 2021

Thanks again. The changes should be released soon once GitHub Actions are functioning again

@github-actions
Copy link

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@z0al z0al z0al approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@branikclimbs @z0al