Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash when adding a word and there's no study deck created yet. #4

Closed
gyan000 opened this issue Aug 9, 2017 · 3 comments
Closed

crash when adding a word and there's no study deck created yet. #4

gyan000 opened this issue Aug 9, 2017 · 3 comments
Assignees

Comments

@gyan000
Copy link

gyan000 commented Aug 9, 2017

Hello,

All is almost explained in the subject issue.

How to reproduce
dictionary search mode -> search a kanji -> in the list view result, right-click -> "Add word to study deck"

I don't know what is the best option here :

  • Create a default study deck when we select the option "Add word to study deck".
  • Or a popup warning, asking to user to create a study deck.
  • Or create a default study deck at startup if there's no one.
  • Or display the study deck configuration window (perhaps the best here)

Logs
qtcreator_debugger.txt
backtrace.txt

note : zkanji v0.0.3-alpha (fedora 26)

Thanks

@z1dev
Copy link
Owner

z1dev commented Aug 10, 2017

Thanks for reporting that.

I think I'll go with the automatic deck creation when the user tries to add words to decks. That sounds the most natural.

@z1dev z1dev self-assigned this Aug 10, 2017
@z1dev
Copy link
Owner

z1dev commented Aug 18, 2017

A new deck called "Deck 1" is now created when trying to study with a deck and there's no deck in the dictionary.

@z1dev z1dev closed this as completed Aug 18, 2017
@gyan000
Copy link
Author

gyan000 commented Aug 18, 2017

Working as expected, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants