Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug default routing config has few bugs #25

Closed
mrlinnth opened this issue Nov 17, 2022 · 0 comments
Closed

Bug default routing config has few bugs #25

mrlinnth opened this issue Nov 17, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mrlinnth
Copy link
Contributor

Default routing config is

    'routing' => [
        'enabled' => true,
        'prefix'  => null, //    /pages
    ],

With default values, you will receive 404 errors for non-filament routes with ModelNotFoundException for No query results for model [Z3d0X\FilamentFabricator\Models\Page].

1st workaround is to disable the routing but then you won't be able to use fabricator page routes.

2nd workaround is to use a prefix for the fabricator routing eg: pages.

However non-null prefix values cause another minor bug for the Visit action of Page resource.

Filament default route prefix is /admin and fabricator will send you to /admin/pages/xyz instead of /pagess/page-xyz when you click the Visit action of your fabricator page.

@Z3d0X Z3d0X added the bug Something isn't working label Nov 21, 2022
@Z3d0X Z3d0X closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants