Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Documentation of Struct Fields in BigQuery #32

Closed
brandon-segal opened this issue Nov 29, 2022 · 3 comments · Fixed by #35
Closed

Support Documentation of Struct Fields in BigQuery #32

brandon-segal opened this issue Nov 29, 2022 · 3 comments · Fixed by #35

Comments

@brandon-segal
Copy link

Proposed Behavior

When a user runs dbt-osmosis yaml document it will also pull in and preserve struct level documentation of fields in bigquery projects.

Current behavior

When there are struct fields in the schema.yml or source.yml the process removes any struct documentation that is specified as a field like name: struct.struct_field

Specifications

  • dbt version: 1.2.0
  • python version: 3.8.10
@riordan
Copy link

riordan commented Jan 20, 2023

This would be incredibly useful, particularly when building staging models that have infrequently-accessed, grouped fields. This can save massively on query costs while preserving context for folks who don't have to hunt around and perform the right join when they need it.

@brandon-segal
Copy link
Author

@riordan Just added a PR #35, which primarily aims at addressing the struct fields by updating how dbt-osmosis retrieves the column names.

@brandon-segal
Copy link
Author

@z3z1ma I am not sure what the contribution process is like but I'd love to use this tool and I'm sure many others who use BigQuery would also like to use it. Would love to get your thoughts on the PR #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants