You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our environment people write everything in lower case including both the SQL and the YML. It looks like the SNOWFLAKE adapter consistently returns column names as upper case. Can you provide an option to ignore case in comparisons of column names between the YML version and the DB?
I "fixed" this locally by changing this line to read c.name.lower() in the obvious place:
But you might instead want to keep that case and modify all the places where you compare columns to do a case insensitive comparison. Looks like you're using python sets for the different column lists. I don't know how you'd make them case insensitive, so just adding the lower() maybe as a configuration would be great.
The text was updated successfully, but these errors were encountered:
I am going to mark this as resolved as my last commit has made column comparison case insensitive. Can you post another issue @kylebutler-sf with a stack trace and I am happy to take a look.
In our environment people write everything in lower case including both the SQL and the YML. It looks like the SNOWFLAKE adapter consistently returns column names as upper case. Can you provide an option to ignore case in comparisons of column names between the YML version and the DB?
I "fixed" this locally by changing this line to read
c.name.lower()
in the obvious place:dbt-osmosis/src/dbt_osmosis/main.py
Line 438 in 05ed698
But you might instead want to keep that case and modify all the places where you compare columns to do a case insensitive comparison. Looks like you're using python sets for the different column lists. I don't know how you'd make them case insensitive, so just adding the
lower()
maybe as a configuration would be great.The text was updated successfully, but these errors were encountered: