Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potion Rings don't work in Inventorio's additional slots #110

Closed
JumperREDACTED opened this issue Jun 15, 2021 · 5 comments
Closed

Potion Rings don't work in Inventorio's additional slots #110

JumperREDACTED opened this issue Jun 15, 2021 · 5 comments
Labels
bug The bug has been recognized Fabric

Comments

@JumperREDACTED
Copy link

Describe the bug
Potion Ring's don't activate if placed into Inventorio's additional slots. (Either slots gained from the deep pocket enchantment, or the additional offhand slots.)
https://github.com/Lizard-Of-Oz/Inventorio/issues/31

Pastebin links

  • latest.log: was too long for pastebin
    latest.log

Environment (please complete the following information):

  • Mod Version: 1.4.5
  • MC Version: 1.16.5
  • Fabric Version: 0.11.3
  • Fabric API version: 0.34.6
  • System: W10
  • Installation type: either
@zabi94
Copy link
Owner

zabi94 commented Jun 15, 2021

Potion rings only work in ticking slots, inventorio must implement item ticking in its logic to be compatible

@zabi94
Copy link
Owner

zabi94 commented Jun 15, 2021

Problem is, inventory ticking is not as straightforward to add as one might think. Many mods would probably crash or work weirdly, because they must be supplied with the inventory slot, but there is no way of telling the item what inventory to look in.

As a result, telling the item it is in slot 1 might cause the item's mod to look into the vanilla inventory slot 1, belonging to another item

@Lizard-Of-Oz
Copy link

Inventorio author here.
I'll implement an API for custom Inventorio ticking in a day or two (and some extra functionality for that matter).
It won't make things magically work with all mods, but will allow other mods to call Inventorio's item ticking, like with Trinkets or Curios.

@zabi94
Copy link
Owner

zabi94 commented Jun 16, 2021

Works for me. I'll subscribe to the issue on your side to be notified when it closes, I'll close this one

@zabi94 zabi94 closed this as completed Jun 16, 2021
@zabi94
Copy link
Owner

zabi94 commented Jul 4, 2021

Implemented in 1.17 alpha build.
I couldn't do 1.16.4 because of a temporary problem (terraformersMC maven repo being down, used for many dependencies in ea), but I hope they will fix it by next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The bug has been recognized Fabric
Projects
None yet
Development

No branches or pull requests

3 participants