Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace sum() with + in calibrate_thresholds() for two-sample case #19

Closed
zabore opened this issue Apr 5, 2023 · 0 comments · Fixed by #20
Closed

replace sum() with + in calibrate_thresholds() for two-sample case #19

zabore opened this issue Apr 5, 2023 · 0 comments · Fixed by #20
Assignees
Labels
bug Something isn't working

Comments

@zabore
Copy link
Owner

zabore commented Apr 5, 2023

There is a code mistake on lines 365 and 369 in calibrate_thresholds()
Need to replace prop_stopped_null = mean(sum(n0_null, n1_null) < sum(N)) with prop_stopped_null = mean((n0_null + n1_null) < sum(N)) on line 365 and prop_stopped_alt = mean(sum(n0_alt, n1_alt) < sum(N)) with prop_stopped_alt = mean((n0_alt + n1_alt) < sum(N)) on line 369.

@zabore zabore added the bug Something isn't working label Apr 5, 2023
@zabore zabore self-assigned this Apr 5, 2023
@zabore zabore closed this as completed in #20 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant