Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom messageId when sending SMSs #47

Closed
Xsmael opened this issue Oct 2, 2019 · 3 comments
Closed

Custom messageId when sending SMSs #47

Xsmael opened this issue Oct 2, 2019 · 3 comments

Comments

@Xsmael
Copy link

Xsmael commented Oct 2, 2019

Hello,
Is it possible to supply a custom made messageId, when sending an sms ?

@Xsmael
Copy link
Author

Xsmael commented Oct 2, 2019

Okay, I finally found my way out in modem.js to add it optionally

line 513

- modem.sendSMS = function (number, message, alert = false, smsId, callback) {
+ modem.sendSMS = function (number, message, alert = false, smsId, callback) {

line 527

- let messageID = modem.makeId(25);
+ let messageID = smsId || modem.makeId(25);

so it will be nice if you can add that
Thanks.

@Apollon77
Copy link
Contributor

Can you prepare a PR?

@Xsmael
Copy link
Author

Xsmael commented Oct 2, 2019

sure

@Xsmael Xsmael closed this as completed Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants