Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append the current release's changelog body to the git tag message #43

Closed
frankdugan3 opened this issue Jan 8, 2021 · 4 comments
Closed
Assignees
Labels
good first issue Good for newcomers

Comments

@frankdugan3
Copy link
Contributor

This will have several benefits, particularly that with GitHub releases, the tag's message will be added into the body.

As @zachdaniel mentioned in a Discord conversation, the implementation should be pretty easy to add:

We'll probably need to update the Changelog.write!/5 function to return the text contents that it wrote to the changelog, and then pass that into the confirm_and_tag function

@zachdaniel zachdaniel added the good first issue Good for newcomers label Jan 8, 2021
@zachdaniel
Copy link
Owner

I won't have much time to focus on this, but I'll try to get around to it in the next couple weeks. If anyone else wants to tackle it I'd be grateful.

@zachdaniel zachdaniel self-assigned this Jan 8, 2021
@frankdugan3
Copy link
Contributor Author

I may take a stab at this. Do you think it would be better for Changelog.write/5 to return just the new_content, or perhaps a map/tuple containing both the entire changelog and new_content?

@zachdaniel
Copy link
Owner

Probably just the new_content since the whole file itself isn't needed for anything further down the line.

@zachdaniel
Copy link
Owner

This was completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants