Away batting?

[JonathanSFalk]

Hi. I just came across this fantastic piece of work today. Thanks so much. I'm fairly new to Python, but I can't figure out what I'm doing wrong. This piece of code:

stats = mlbgame.player_stats(game.game_id)
   for player in stats.home_batting:
    ... stuff here on player

works fine
But this code

stats = mlbgame.player_stats(game.game_id)
    for player in stats.away_batting:
     ... stuff here on player

Never executes because away_batting is always empty. I presume I'm doing something wrong, but if I'm not....

[panzarino]

I think it should work, it may not since I recently changed the way that the algorithm works for that section. Are the away players showing up in the home section or are they just not there at all? Is this an issue isolated to a specific game or happening for all of them?

[JonathanSFalk]

They are not showing up at all, and it is happening for all games, or at least I think it is. All I was doing was writing code to get all home runs hit in June 2017, and I was surprised to see all I got was the home runs hit by home players. (To be honest, I learned a lot just by investigating why it wasn't working, but I couldn't figure out enough to make it work... )

[panzarino]

@JonathanSFalk I'll investigate more today and try to fix it, if I can't then I'll revert to the old version.

[ajbowler]

@JonathanSFalk can you pull latest master and give it another go?

[panzarino]

@JonathanSFalk @ajbowler Adding on to that, a release with the fix should be coming by this weekend at the latest, theres a few more things I want to fix before releasing.

[JonathanSFalk]

Should have time to look at it tonight. Thx to both of you.

…

On Jan 30, 2018 4:49 PM, "Zach Panzarino" ***@***.***> wrote: @JonathanSFalk <https://github.com/jonathansfalk> @ajbowler <https://github.com/ajbowler> Adding on to that, a release with the fix should be coming by this weekend at the latest, theres a few more things I want to fix before releasing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#57 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiNQIj6QEteTARdda58l7kXUD-enHF-Pks5tP45-gaJpZM4RvjXi> .

[JonathanSFalk]

Works! Thanks!

…

On Tue, Jan 30, 2018 at 4:49 PM Zach Panzarino ***@***.***> wrote: @JonathanSFalk <https://github.com/jonathansfalk> @ajbowler <https://github.com/ajbowler> Adding on to that, a release with the fix should be coming by this weekend at the latest, theres a few more things I want to fix before releasing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#57 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiNQIj6QEteTARdda58l7kXUD-enHF-Pks5tP45-gaJpZM4RvjXi> .