Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close last tab page #2298

Closed
1 task done
Nriver opened this issue Nov 1, 2021 · 3 comments
Closed
1 task done

close last tab page #2298

Nriver opened this issue Nov 1, 2021 · 3 comments

Comments

@Nriver
Copy link
Contributor

Nriver commented Nov 1, 2021

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe feature

I noticed in the latest 0.48.4 that the last tab page can not be closed. In previous versions, last page was closable. Would you add an option for this config?

Additional Information

No response

@agentydragon
Copy link
Sponsor Contributor

I think this is duplicate of #2212.

@Nriver
Copy link
Contributor Author

Nriver commented Nov 1, 2021

I think this is duplicate of #2212.

No, not the same actually. I want to keep Trilium running even if the last tab is closed, just like the how 0.47 works.

I think ctrl+w should handle only tabs, not close the application. ctrl+q is the one to close the whole application.

@zadam zadam closed this as completed in fc46398 Nov 1, 2021
@zadam
Copy link
Owner

zadam commented Nov 1, 2021

Hi, the way it was done before (closing and opening new empty tab) was prone to race conditions when closing the tabs quickly, that's why I changed the behavior.

I've now made a change which simulates the old behavior - it doesn't close the last tab, just opens the empty screen which is functionally (almost) the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants