(Bug report) Evernote import places images and attachments at end

[avidrissman]

Trilium Version

0.57.5

What operating system are you using?

Other Linux

What is your setup?

Server access only

Operating System Version

Docker, on a Synology

Description

Note Export.1.enex.zip
^ was generated by Evernote Legacy

When imported, this does not place the images in their correct location.

I have my suspicions as to why. In enex.js:

trilium/src/services/import/enex.js

Line 272 in 43c5163

const mediaRegex = new RegExp(`<en-media hash="${hash}"[^>]*>`, 'g');

the regex matches en-media elements in which the hash attribute comes first. However, in this enex file, there is:

<en-media type="image/png" hash="bebf29eaebe00ea01693b4763c3484f1"/>

In other enexes (that are private and that I can’t share) I see:

<en-media style="--en-naturalWidth:1125; --en-naturalHeight:501;" hash="60ff10477080d28c820209a3f681c045" type="image/png" />
<en-media style="width: 160px; height: 120px;" hash="e4581e956a062139aed4788cc4b90009" type="audio/x-m4a" title="Attachment"/>

You may need to expand the regex you use.

Thanks for being so responsive!

Error logs

No response

[zadam]

Thanks, fixed based on the sample import you provided.

[contributor]

All images are still at the bottom of the note.
Evernote:

Trilium:

In my case source of trilium note is the same either before and after f738787 applied over tag v0.57.5

<div>First line, first image follows</div>
<div></div>
<div>Second line, first image follows</div>
<div>
  <br>
</div>
<div></div>
<div>
  <br>
</div>
<img src="api/images/zQI3GBFdTIzx/Image.png">
<img src="api/images/WMRVotHpWxwY/image.png">

[contributor]

Test enex file with the note above:
EnexImages.enex.zip

[zadam]

There was another fix for this a couple of days ago. You need to use master branch.

<div>First line, first image follows</div>
<div>
  <img src="api/images/81sqKw2DqxyT/Image.png">
</div>
<div>Second line, first image follows</div>
<div>
  <br>
</div>
<div>
  <img src="api/images/PQePFzr2Wevb/image.png">
</div>
<div>
  <br>
</div>

[contributor]

Included e40f1fd and now it works!

Thank you!