Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve robustness #106

Merged
merged 3 commits into from Oct 3, 2020
Merged

Feature/improve robustness #106

merged 3 commits into from Oct 3, 2020

Conversation

zaibacu
Copy link
Owner

@zaibacu zaibacu commented Oct 3, 2020

In general - measure how long it takes to compile and avoid situations when pattern creates infinite loop (possible to get to this situation using regex).

Closes: #78

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #106 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   93.40%   93.46%   +0.06%     
==========================================
  Files          16       16              
  Lines         788      796       +8     
  Branches      148      149       +1     
==========================================
+ Hits          736      744       +8     
  Misses         35       35              
  Partials       17       17              
Impacted Files Coverage Δ
rita/engine/translate_standalone.py 93.44% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4628197...fa0110c. Read the comment docs.

@zaibacu zaibacu merged commit 56770e5 into master Oct 3, 2020
@zaibacu zaibacu deleted the feature/improve_robustness branch October 3, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measure how long it took to compile rules
1 participant